Skip to content

fix(rendering): optimize row height initialization in VirtualDomVertical #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(rendering): optimize row height initialization in VirtualDomVertical #4814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/js/core/rendering/renderers/VirtualDomVertical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,27 +310,29 @@ export default class VirtualDomVertical extends Renderer{
}

element.appendChild(rowFragment);
// NOTE: The next 3 loops are separate on purpose
// This is to batch up the dom writes and reads which drastically improves performance

// NOTE: The next 4 loops are separate on purpose
// This is to batch up the dom writes and reads which drastically improves performance

renderedRows.forEach((row) => {
row.rendered();
});

const rowsNeedingHeightInit = [];
renderedRows.forEach((row) => {
if(!row.heightInitialized) {
row.calcHeight(true);
rowsNeedingHeightInit.push(row);
}
});

renderedRows.forEach((row) => {
if(!row.heightInitialized) {
row.setCellHeight();
}
rowsNeedingHeightInit.forEach((row) => {
row.setCellHeight();
});

renderedRows.forEach((row) => {
rowHeight = row.getHeight();

if(totalRowsRendered < topPad){
topPadHeight += rowHeight;
}else {
Expand Down