fix(browser): transform maxResults to max_results for WebSearch API#284
Open
abdelhadi703 wants to merge 1 commit into
Open
fix(browser): transform maxResults to max_results for WebSearch API#284abdelhadi703 wants to merge 1 commit into
abdelhadi703 wants to merge 1 commit into
Conversation
The WebSearchRequest interface uses camelCase (maxResults), but the Ollama API expects snake_case (max_results). The spread operator was passing the wrong parameter name to the API. This fix explicitly maps the request parameters to the correct API parameter names, ensuring max_results is sent instead of maxResults. Fixes ollama#283 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
WebSearchRequestinterface uses camelCase (maxResults), but the Ollama/api/web_searchendpoint expects snake_case (max_results). The spread operator was passing the wrong parameter name.Problem
The previous code used
{ ...request }which sentmaxResultsinstead ofmax_results.Solution
Explicitly map the request parameters to the correct API parameter names:
Fixes #283