Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixed pipeline - should run on every action for code quality checks #323

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

Subhrans
Copy link

@Subhrans Subhrans commented Jun 8, 2024

  • Added black formatting steps to check whether the codes are formatted or not before merge
  • Fixed pipeline - should run on every action for code quality checks

- Added black formatting steps to check whether the codes are formatted or not before merge
@Subhrans Subhrans closed this Jun 8, 2024
- Added black formatting steps to check whether the codes are formatted or not before merge
@Subhrans Subhrans reopened this Jun 8, 2024
@Subhrans
Copy link
Author

Subhrans commented Jun 8, 2024

Hi @olucurious ,
I have added black formatting steps as the codes are not formatted with guidelines, Could you check my changes?

The pipeline failed because codes are not formatted and I haven't pushed the formatted code in this PR. But I have done the formatted code in another PR (pull request) #322.

Also, I modified the pipelines because I think the pipeline should run on every push to any branch. because it ensures the developer's codes are correct with test cases and clean code.

Please let me know
Thank you

@Subhrans
Copy link
Author

Subhrans commented Jun 8, 2024

Hi @olucurious ,
If you are okay with this PR, you change the target branch to develop branch for correct flow.
Thanks

@olucurious olucurious changed the base branch from master to develop June 8, 2024 16:06
@olucurious olucurious merged commit bee89b1 into olucurious:develop Jun 8, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants