Switch twitter by bluesky for openmicroscopy.org #764
Conversation
There was a problem hiding this comment.
I think this one https://github.com/ome/www.openmicroscopy.org/pull/764/files#r1922220863 should be amended too, this is in lines with the changes you have just done in the footer ?
|
Is the missing icon expected ? |
Co-authored-by: pwalczysko <[email protected]>
|
@sbesson @joshmoore @will-moore one of the changes in this PR is to use external fontawesome css (I have not deleted the one in this repo) |
👍 Is the new style expected to be loaded from the CDN in production? Or should it be cached under https://github.com/ome/www.openmicroscopy.org/tree/master/css like previous FontAwesome and other styles used by the website? |
|
That is the question, what is the general view about using external vs internal |
Sorry, obviously I have approved this PR. But thiking through the discussion here, I do not like the idea that icons on the prod www.op..py.org would vanish because external server X is down (we see similar problems with the linkchecker) and thus I would lean towards caching. |
|
Definitely no objections to pulling it in if we've done that in the past, I assume following https://docs.fontawesome.com/web/setup/host-yourself/webfonts |
|
https://snoopycrimecop.github.io/www.openmicroscopy.org/ |
I went through all the pages manually on snoopy. New icon But lgtm |
Update link
Icons will need to be reviewed