Filtered visible sites on cross site search to only sites the user has permission to view ##2341
Open
C-Norton wants to merge 6 commits intoomeka:developfrom
Open
Filtered visible sites on cross site search to only sites the user has permission to view ##2341C-Norton wants to merge 6 commits intoomeka:developfrom
C-Norton wants to merge 6 commits intoomeka:developfrom
Conversation
Added code to limit the display of item results to visible sites
made changes to show results only from sites with which the user has permission to view
…item-results.phtml and results.phtml changes, cleaned up comments in item-results.phtml and results.phtml These changes will ensure that only sites, items, and item sets that the user has permission to view will be visible on cross site search results
integrating upstream changes prior to PR
# Conflicts: # application/view/common/cross-site-search/item-results.phtml # application/view/common/cross-site-search/results.phtml
Author
|
@zerocrates any chance this could get rolled into the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added appropriate unit tests (hopefully in the right directory). This aligns with issue 2293. Made this change for item sets as well