Repository navigation
chore: restore pub(super) on placeholders and say title tiebreak - #2732
Merged
Merged
Conversation
Contributor
cargo-auditNo RustSec advisories found in Posted by the Rust workflow's |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation fixes are accurate, with only a nonblocking visibility-style concern.
1 open finding
What changed in this PR
Corrects offline-sort documentation and adjusts the SQL placeholder helper’s visibility.
Changes:
- Updates comments to name the title tiebreak correctly.
- Changes
placeholderstopub(super).
| File | Description |
|---|---|
docs/architecture.md |
Corrects offline replica tiebreak documentation. |
db/src/books/projection.rs |
Corrects the projection comment. |
db/src/books/page.rs |
Changes helper visibility. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…-nits # Conflicts: # docs/architecture.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
pub(super)onpage::placeholders, per rule 05's visibility ruleTest plan
cargo nextest run -p omnibus-db books::page→ 58 passedcargo fmt --checkclean; clippy reports nothing in the touched filesVersion
By default a merge to
maincuts a patch release. Pick the version update this PR should trigger; labels override the default:minor versionlabel (vX.Y.Z→vX.(Y+1).0).patch versionlabel or leave unlabeled (vX.Y.Z→vX.Y.(Z+1)).no releaselabel to skip cutting a release.If both
minor versionandpatch versionare applied,minor versionwins. Unlabeled PRs that only touch docs (*.md,docs/) or CI (.github/) skip the release automatically.