Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update username regex and more #68

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Update username regex and more #68

merged 6 commits into from
Sep 19, 2024

Conversation

FrankApiyo
Copy link
Contributor

@FrankApiyo FrankApiyo commented Sep 18, 2024 •
edited
Loading

Changes introduced

  • Use email address to set username when provided username is invalid
  • Update default username regex (don't allow less than 3 characters)
  • Update tests
  • Update CI

@FrankApiyo FrankApiyo changed the title Update username regex and more [WIP]Update username regex and more Sep 18, 2024
@FrankApiyo FrankApiyo changed the title [WIP]Update username regex and more Update username regex and more Sep 18, 2024
ukanga
ukanga reviewed Sep 18, 2024
View reviewed changes
@FrankApiyo FrankApiyo force-pushed the update-username-regex-and-more branch from 33292ed to 7427d35 Compare September 19, 2024 07:21
@FrankApiyo FrankApiyo force-pushed the update-username-regex-and-more branch from 77f9d05 to 80c2708 Compare September 19, 2024 07:43
@FrankApiyo FrankApiyo requested a review from ukanga September 19, 2024 07:46
@FrankApiyo FrankApiyo merged commit 7577b15 into main Sep 19, 2024
10 checks passed
@FrankApiyo FrankApiyo deleted the update-username-regex-and-more branch September 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@kelvin-muchiri kelvin-muchiri Awaiting requested review from kelvin-muchiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankApiyo @ukanga