Revert changes for Win static hwloc #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. "enable building examples on win static hwloc CI" This reverts commit 58ba8e9. 2. "fix setting LIBHWLOC_LIBRARIES on Windows" This reverts commit 91f14d7. Ref. oneapi-src#1016
|
Are you reopening the #1016 issue? |
PatKamin
approved these changes
Jan 27, 2025
bratpiorka
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. old PR: #1016
Ref. new issue: #1057
Reverting for now, as it fails the intel/llvm build: https://github.com/intel/llvm/actions/runs/12933269748/job/36071488569
Draft as still waiting for Windows SYCL build to finish: intel/llvm#16749UR and intel/llvm builds looks good:
oneapi-src/unified-runtime#2596
intel/llvm#16749