Call zeInitDrivers in L0 provider #1101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroy base alloc last, as other destroy functions might call umf_ba_global_free()
According to the L0 spec, zeInitDrivers must be called (by every library) before calling any other APIs. Not calling zeInitDrivers causes crash when using statically linked L0 loader in UR.
|
The tests are failing on CI most likely because we have an older L0 loader version installed and zeInitDrivers might not work. I'm not sure if we need to support older version so perhas we can just update the runners? If we do need to support older version, we will probably need to implement a fallback to zeInit (which is supported by older loaders but deprecated now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on: https://github.com/oneapi-src/unified-memory-framework/pull/1086/files
And fixes problems in oneapi-src/unified-runtime#2667