Remove UMF_DISABLE_HWLOC option #1228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
remove-disable-hwloc
branch
3 times, most recently
from
732203e to
5229bc6
Compare
PatKamin
force-pushed
the
remove-disable-hwloc
branch
from
5229bc6 to
29de648
Compare
bratpiorka
reviewed
Apr 16, 2025
| set(UMF_COMMON_COMPILE_DEFINITIONS ${UMF_COMMON_COMPILE_DEFINITIONS} | ||
| "UMF_NO_HWLOC=1") | ||
| endif() | ||
| set(UMF_SOURCES ${UMF_SOURCES} ${HWLOC_DEPENDENT_SOURCES} |
There was a problem hiding this comment.
this 3 lines could e merged with common sources, libs and dirs lists
bratpiorka
reviewed
Apr 16, 2025
| @@ -50,6 +50,8 @@ function(build_umf_test) | |||
|
|
|||
| set(LIB_DIRS ${LIB_DIRS} ${LIBHWLOC_LIBRARY_DIRS}) | |||
|
|
|||
| set(INC_DIRS ${INC_DIRS} ${LIBHWLOC_INCLUDE_DIRS}) | |||
There was a problem hiding this comment.
remove an empty line above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After all third-party usage of the
UMF_DISABLE_HWLOCis removed, the flag itself can be removed. It was a temporary workaround for UMF usage without the hwloc installed in the system, from the beginning planned to be removed prior to the v1.0 first stable API release.Currently, UMF either uses libhwloc-dev installed in the system or fetches it from sources.
Fixes: #1047
Checklist