Improve coarse_alloc()
#1249
Open
Improve coarse_alloc()
#1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The sanitizers CI builds fail, because #1225 has not been merged yet. |
KFilipek
reviewed
Apr 11, 2025
| *resultPtr = NULL; | ||
| // If the block that we want to reuse has a greater size, split it. | ||
| // Try to merge the split part with the successor if it is not used. | ||
| enum { ACTION_NONE = 0, ACTION_USE, ACTION_SPLIT } action = ACTION_NONE; |
There was a problem hiding this comment.
ACTION_NONE
AFAIK, starting enum entry is 0, so there is no need to set it up.
There was a problem hiding this comment.
Right, but IMHO it is more readable as it is now
KFilipek
reviewed
Apr 11, 2025
ldorau
force-pushed
the
Refactor_coarse_alloc
branch
from
609a850 to
fd816f5
Compare
lplewa
reviewed
Apr 11, 2025
ldorau
force-pushed
the
Refactor_coarse_alloc
branch
from
fd816f5 to
2718712
Compare
ldorau
force-pushed
the
Refactor_coarse_alloc
branch
from
2718712 to
7a075dd
Compare
Refactor coarse_alloc(): move the code responsible for handling the `(curr == NULL)` case just after `curr = find_free_block()`. Add coarse_add_free_block(). Now (before this change) when a user calls `coarse_alloc(1, 2MB)` (allocate 1 byte with 2MB alignment) and there is no suitable blok inside the coarse allocator, a new block is allocated from the provider of size `coarse->page_size` at least, but it is added to the inner lists with the requested size of only 1 byte and the rest of space will not be able to be utilized. After this change, when a user calls `coarse_alloc(1, 2MB)` (allocate 1 byte with 2MB alignment) and there is no suitable blok inside the coarse allocator, a new block is allocated from the provider of size `alignment` (>= `coarse->page_size`) and it is added to the inner lists with the `alignment` size. The new free block will be used as a whole or split and the rest of space can be utilized later. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Refactor_coarse_alloc
branch
from
7a075dd to
3a8cbaa
Compare
lplewa
approved these changes
Apr 14, 2025
|
@bratpiorka please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve
coarse_alloc(): move the code responsible for handling the(curr == NULL)case just aftercurr = find_free_block(). Addcoarse_add_free_block().Now (before this change) when a user calls
coarse_alloc(1, 2MB)(allocate 1 byte with 2MB alignment) and there is no suitable blok inside the coarse allocator, a new block is allocated from the provider of sizecoarse->page_sizeat least, but it is added to the inner lists with the requested size of only 1 byte and the rest of space will not be able to be utilized.After this change, when a user calls
coarse_alloc(1, 2MB)(allocate 1 byte with 2MB alignment) and there is no suitable blok inside the coarse allocator, a new block is allocated from the provider of sizealignment(>=coarse->page_size) and it is added to the inner lists with thealignmentsize. The new free block will be used as a whole or split and the rest of space can be utilized later.The sanitizers CI builds fail, because #1225 has not been merged yet.
Checklist