[CI] Install hwloc from apt instead of building from sources #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Apr 15, 2025
.github/workflows/reusable_basic.yml
Outdated
| @@ -124,7 +124,7 @@ jobs: | |||
| - name: Install apt packages | |||
| run: | | |||
| sudo apt-get update | |||
| sudo apt-get install -y clang cmake libnuma-dev lcov | |||
| sudo apt-get install -y clang cmake libhwloc-dev libnuma-dev lcov | |||
There was a problem hiding this comment.
I think HWLOC should be installed only when disable_hwloc == OFF ?
There was a problem hiding this comment.
It should, but it wasn't. It was always installed, so I've left the logic intact in this PR. Anyway, the proposed change is a small one, I'll include it in this PR.
Get rid of the installation script runs in CI. Save ca. 25s in each of 14 jobs using this script.
PatKamin
force-pushed
the
remove-hwloc-install
branch
from
577dc96 to
c0bc9c9
Compare
bratpiorka
approved these changes
Apr 16, 2025
lukaszstolarczuk
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the hwloc installation script runs in CI. Save ca. 25s in each of 14 jobs using this script.
Description
Checklist