Merge fixes for v0.11.0 #1277
Merged
Merge fixes for v0.11.0 #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when UMF_USE_DEBUG_POSTFIX CMake option is set.
- add installation tests step to Windows generators nightly tests
Signed-off-by: Lukasz Dorau <[email protected]>
In case of error in the init function, cleanup was being called on 'provider' which was being initialized at the very end of init function, instead of 'ze_provider'.
Signed-off-by: Lukasz Dorau <[email protected]>
`new_offset_mmap` can be greater than `file_provider->size_mmap`, so `file_provider->size_mmap - new_offset_mmap` would be an underflow in this case. Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
bratpiorka
approved these changes
Apr 17, 2025
|
Changes in my commits LGTM |
PatKamin
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks of:
Am I missing some changes important for v0.11.0 release?