[L0] Manage UMF pools through usm::pool_manager #2495
+245
−500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
common
kswiecicki
force-pushed
the
l0-pool-manager
branch
from
8b14272 to
223fd4e
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
5 times, most recently
from
b00072c to
2a62983
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
2 times, most recently
from
281e3e4 to
30d5386
Compare
igchor
reviewed
Jan 13, 2025
source/common/ur_pool_manager.hpp
Outdated
| @@ -289,6 +289,12 @@ template <typename D> struct pool_manager { | |||
|
|
|||
| return it->second.get(); | |||
| } | |||
|
|
|||
| bool hasPool(umf_memory_pool_handle_t hPool) noexcept { | |||
There was a problem hiding this comment.
One UR pulls down this commit oneapi-src/unified-memory-framework@86d2341 hasPool won't be necessary - you will be able to just use umfPoolByPtr
There was a problem hiding this comment.
I've decided not to include the umfPool[Set/Get]Tag changes in this PR. After trying to implement it I've encountered some complications in ur_result_t ur_validation_layer::bounds(ur_queue_handle_t, const void*, size_t, size_t) from ur_validation_layer.cpp.
kswiecicki
force-pushed
the
l0-pool-manager
branch
from
30d5386 to
cdbec07
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
3 times, most recently
from
44fcaa0 to
51fec4f
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
2 times, most recently
from
8a2b671 to
38752a1
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
3 times, most recently
from
b7a42f9 to
9bc686d
Compare
kswiecicki
force-pushed
the
l0-pool-manager
branch
4 times, most recently
from
8023b0a to
5ee6a87
Compare
This variable is not initialized in any way and it is set to nullptr by default.
Level Zero provider internally stores native errors of ur_result_t type.
kswiecicki
force-pushed
the
l0-pool-manager
branch
from
5ee6a87 to
5022823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.