Improvements to align CTS and Spec for Device #2597
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
4 times, most recently
from
37c3c32 to
b8a9271
Compare
martygrant
added a commit
to martygrant/llvm
that referenced
this pull request
Jan 23, 2025
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
b8a9271 to
774c13c
Compare
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case - oneapi-src#2290 - Remove the UR/OpenCL Device enum map function - no point maintaining both a switch case and a separate mapping function - Update some spec wording for consistency - Add missing Device info enums to OpenCL adapater - Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE - Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h - Update spec to say info queries that return char[] are null-terminated - Update UR_DEVICE_INFO_MAX_IMAGE_LINEAR_WIDTH/HEIGHT/PITCH should be uint32_t, matching SYCL RT - Add missing unsupported device enums to HIP adapter
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
774c13c to
e96d2c5
Compare
martygrant
force-pushed
the
martin/device-cts-spec-gap-redo
branch
from
2cab273 to
1ce6d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm#16746