added filename and line number to logs

[lslusarczyk]

Added an option to print line number and filename in log file. When fileline:1 is specified in an environment variable describing log, e.g:

UR_LOG_LEVEL_ZERO="level:debug;flush:warning;fileline:1;output:file,juju-l0.log"

then instead of seeing logs like this

<LEVEL_ZERO>[DEBUG]: create command list ..., inOrder: 1

one will see log like this:

<LEVEL_ZERO>[DEBUG]: create command list ..., inOrder: 1 <source/adapters/level_zero/v2/command_list_cache.cpp:73>

Review seems to be big but in fact is much shorter. The only essential change are some changes in

• ur_logger.hpp (removed unused functions)
• ur_logger_details.hpp (added macro, removed unused functions)
• ur_sinks.hpp parsing new env var parameter
• two lines in CMakeLists.txt

The rest was automated change of log statements from logger::xxx(...) to URLOG(XXX, ...)

[pbalcer]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

[pbalcer]

why a macro and not a function?
nvm, I didn't look at the code. We'd need __LINE__...

[lslusarczyk]

This has to be a macro because we need __LINE__ and __FILE__ from the place of log statement, not from the place of of function definition.

[lslusarczyk]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

My opinion is that filename and line number is crucial for efficient log analysis, unless you work for a long time in a project and perfectly know the code. When I realized UR don't have it I feel it is a must - hence the PR.

Still when writing a log statement one can write it in old way and in this case log statement will appear without line and number.

[pbalcer]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

My opinion is that filename and line number is crucial for efficient log analysis, unless you work for a long time in a project and perfectly know the code. When I realized UR don't have it I feel it is a must - hence the PR.

Still when writing a log statement one can write it in old way and in this case log statement will appear without line and number.

Many of the logs, especially error/warning ones, aren't meant for developers, but for users. Anyway, I'm not opposed, but I think this should be an option.

[pbalcer]

Instead of appending the extra information in the macro, instead you might be able to pass it as extra arguments to the log method, and print it out conditionally inside of it.

[lslusarczyk]

applied

[igchor]

@lslusarczyk I think some of the SYCL tests might rely on those log messages being in a specific format. I think you should either make this an option (like Piotr said) or run the tests and see if there are no failures.

[lslusarczyk]

@lslusarczyk I think some of the SYCL tests might rely on those log messages being in a specific format. I think you should either make this an option (like Piotr said) or run the tests and see if there are no failures.

@igchor , @pbalcer I've applied this suggestion. Now behavior does not change unless one will specify "fileline:1" when configuring logs via environment variable.