Improvements to align CTS and Spec for Enqueue #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
martygrant
force-pushed
the
martin/enqueue-cts-spec-gap
branch
2 times, most recently
from
7b7205f to
fe53fda
Compare
- Add test for invalid null pointer for urEnqueueKernelLaunch and urEnqueueUSMFill - Remove redundant sentence in urEnqueueMemBufferMap description - Add advice flag parameters in test for urEnqueueUSMAdvise - Added blocking/non-blocking success tests for urEnqueueDeviceGlobalVariableRead/Write - Added all invalid size scenarios for urEnqueueMemBufferFill and urEnqueueMemBufferWrite/Read/CopyRect - Added to description of urEnqueueMemAdvice to say some adapters will return UR_RESULT_ERROR_ADAPTER_SPECIFIC and allowing this return value in relevant tests
martygrant
force-pushed
the
martin/enqueue-cts-spec-gap
branch
from
fe53fda to
fb0a668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not attached an intel/llvm tag update as the spec change is very minor - just removing a sentence from an entry-point description.