Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L0 v2] add missing urCommadBufferEnqueueExp function #2690

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[L0 v2] add missing urCommadBufferEnqueueExp function #2690

merged 1 commit into from
Feb 11, 2025

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Feb 11, 2025

This is a regression after #2688

@pbalcer pbalcer requested review from a team as code owners February 11, 2025 15:35
@pbalcer pbalcer requested a review from Bensuo February 11, 2025 15:35
@pbalcer
Copy link
Contributor Author

pbalcer commented Feb 11, 2025

ping @Xewar313, please take a look.

@github-actions github-actions bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Feb 11, 2025
EwanC
EwanC approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have messed up my earlier revert, thanks for fixing

@pbalcer pbalcer force-pushed the fix-v2-cmdbuf-enqueue branch from 29e61cf to 0b6e43b Compare February 11, 2025 15:53
@pbalcer pbalcer requested a review from a team as a code owner February 11, 2025 15:53
@pbalcer
Copy link
Contributor Author

pbalcer commented Feb 11, 2025

I ran make generate to remove a leftover function from a template.

@pbalcer pbalcer force-pushed the fix-v2-cmdbuf-enqueue branch from 0b6e43b to 75d536a Compare February 11, 2025 16:12
@kbenzie kbenzie merged commit f66751d into oneapi-src:main Feb 11, 2025
26 checks passed
@kbenzie kbenzie mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@Xewar313 Xewar313 Xewar313 approved these changes

@Bensuo Bensuo Awaiting requested review from Bensuo Bensuo is a code owner automatically assigned from oneapi-src/unified-runtime-command-buffer-write

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification level-zero L0 adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbalcer @kbenzie @EwanC @Xewar313