Fix option name in Low Data Mode documentation#2560
Open
meliharik wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Low Data Mode article documents the option as
.lowDataSource, but that case does not exist.KingfisherOptionsInfo.swift:383declares:lowDataSourceappears nowhere inSources/orTests/outside this one article, so the four occurrences here are the only place it is used. The tests use the real name —ImageViewExtensionTests.swift:934([.lowDataMode(.network(url))]) andKingfisherManagerTests.swift:1141.The first snippet was also missing a closing paren:
swiftc -parsereports 6 errors on that block before the change and 0 after.Documentation only — one file, no code or test changes.