Repository navigation
feat(viewer): make report header logo link back to home - #62
Merged
Merged
Conversation
Wrap the mark + wordmark in an <a href="/"> with aria-label, intercept plain left clicks to route through the SPA onReset path, and let modifier clicks (cmd/ctrl/shift/middle) fall through to the browser so the logo can still open the home page in a new tab. Hover and focus-visible states give the wordmark an amber tint and an outline so keyboard users can see it is interactive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The report page header had an inert
Arguewordmark. Now it is ananchor back to
/, so users on a deep-linked report can return to thelanding page without scrolling to the footer reset button.
<a href="/" aria-label="Argue — back to home">preventDefault()→ SPAonReset()(same path asthe existing "← Check Another Report" button)
/in anew tab natively (SPA's
routeFromPath("/")then renders Landing):focus-visiblegive the wordmark an amber tint + outlineso the affordance is discoverable for both mouse and keyboard
Test plan
npm run format:check,npm run lint,npm run checknpm run test:viewer— 80 / 80 pass (added 2)metaKey: trueclick does not reset (the browser handles the new-tab open instead)npm run dev:viewer, drop a result, verify the logoshows hover tint, focus outline, and that left-click and ⌘-click both
behave as expected