[DRAFT] for optimization #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Res for brevity and consistency in naming conventions
…t to UFix128 for improved precision in calculations fix(UniswapV3SwapConnectors.cdc): update calculations to use UFix128 for consistent handling of decimal values in price impact logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix computation limits in Uniswap V3 connector
Problem
getMaxAmount()was hitting computation limits due to expensive tick bitmap scanning (20-30+ EVM calls per transaction).Solution
Replaced tick-scanning with lightweight price impact heuristic:
Changes
getMaxAmount()calculationmaxPriceImpactBpsparameterTrade-off
Less precise but significantly faster. Sufficient for preventing oversized swap requests.