Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Fix and improve add missing members quick fix #423

Merged
merged 3 commits into from
Aug 31, 2024
Merged

[LS] Fix and improve add missing members quick fix #423

merged 3 commits into from
Aug 31, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Aug 27, 2024 •
edited
Loading

Closes #398

Description

  • Fix access keyword
  • Add view modifier to function, if needed
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Aug 27, 2024
@turbolent turbolent requested a review from SupunS as a code owner August 27, 2024 16:52
@turbolent turbolent merged commit a62af3d into master Aug 31, 2024
10 checks passed
@turbolent turbolent deleted the bastian/398-fix-ls-add-missing-members-quick-fix branch August 31, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
bugfix Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LS] Quick fix -> Add missing members not working properly
2 participants
@turbolent @SupunS