Brian doyle/revamp root #1124
Merged
Brian doyle/revamp root #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
briandoyle81
commented
Jan 28, 2025
•
briandoyle81
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Couple notes:
|
chasefleming
requested changes
Feb 3, 2025
src/components/ActionCardGrid.tsx
Outdated
| sections: { | ||
| title: string; | ||
| title?: string; |
There was a problem hiding this comment.
I dont think the UI supports it being optional right now. I'd change the line below to support that if you want that and make sure to test it.
| @@ -25,4 +25,8 @@ export const colors: Record<ColorOption, { light: string; dark: string }> = { | |||
| light: 'bg-white', | |||
| dark: 'bg-gray-100', | |||
| }, | |||
| flowgreen: { | |||
There was a problem hiding this comment.
Should we just change green to be flow green? or they vary and are both required?
There was a problem hiding this comment.
Both are required. I think the flow green is too neon to use throughout, which is why Fernando did a milder one.
Agreed but don't want perfect to get in the way of good. |
chasefleming
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.