Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Boilerplate Wagmi & Rainbowkit Adapter #2105

Merged
merged 18 commits into from
Feb 8, 2025
Merged

Add Boilerplate Wagmi & Rainbowkit Adapter #2105

merged 18 commits into from
Feb 8, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 3, 2025 •
edited
Loading

Closes #2059
Closes #2060

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 85e0333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the base branch from master to feature/cross-vm February 3, 2025 22:28
@jribbink jribbink changed the title Jribbink/wagmi adpter Add Boilerplate Wagmi & Rainbowkit Adapter Feb 5, 2025
@jribbink jribbink marked this pull request as ready for review February 6, 2025 23:11
@jribbink jribbink requested a review from a team as a code owner February 6, 2025 23:11
@jribbink jribbink marked this pull request as draft February 6, 2025 23:48
@jribbink jribbink force-pushed the jribbink/wagmi-adpter branch from 86a1e04 to 108d40b Compare February 6, 2025 23:49
jribbink
jribbink commented Feb 6, 2025
View reviewed changes
packages/fcl-ethereum-provider/src/cadence.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting (removing leading/trailing new lines in TX) and fixing the get COA script.

@jribbink jribbink marked this pull request as ready for review February 7, 2025 00:42
@jribbink jribbink requested a review from chasefleming February 7, 2025 10:09
chasefleming
chasefleming reviewed Feb 7, 2025
View reviewed changes
packages/fcl-ethereum-provider/src/accounts/account-manager.ts Show resolved Hide resolved
packages/fcl-ethereum-provider/src/accounts/account-manager.ts Show resolved Hide resolved
packages/fcl-wagmi-adapter/src/index.ts
connect = this.onConnect.bind(this)
provider.on("connect", connect)

if (accountsChanged)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this can be abstracted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly a copy+paste thing from Wagmi's repo, so I just used it as is.

@jribbink jribbink merged commit b81429b into feature/cross-vm Feb 8, 2025
1 check passed
@jribbink jribbink deleted the jribbink/wagmi-adpter branch February 8, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming