Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SDK usage examples #447

Merged
merged 23 commits into from
Sep 25, 2023
Merged

Conversation

nozim
Copy link
Contributor

@nozim nozim commented Aug 9, 2023

Description

Update examples folder with running examples.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging
Copy link
Contributor

I believe you forgot to mod tidy @nozim

@nozim
Copy link
Contributor Author

nozim commented Aug 10, 2023

@sideninja updated, thanks 😊

@devbugging
Copy link
Contributor

And make sure to regenerate mocks, it looks like that is failing.

@nozim
Copy link
Contributor Author

nozim commented Aug 10, 2023

yes, also there is another failing example. Will fix in a bit. Thanks

@devbugging
Copy link
Contributor

@chasefleming mind reviewing?

@nozim
Copy link
Contributor Author

nozim commented Sep 6, 2023

@sideninja @chasefleming updated deps and mocks here fc7a435.
Kindly help to review and re run the ci 🙏

@nozim nozim requested a review from tarakby as a code owner September 6, 2023 14:34
@chasefleming
Copy link
Member

@nozim rerunning

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.90% ⚠️

Comparison is base (07814fe) 62.03% compared to head (c8696ba) 61.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   62.03%   61.14%   -0.90%     
==========================================
  Files          25       26       +1     
  Lines        3003     3258     +255     
==========================================
+ Hits         1863     1992     +129     
- Misses       1016     1099      +83     
- Partials      124      167      +43     
Flag Coverage Δ
unittests 61.14% <ø> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
access/grpc/client.go 0.00% <ø> (ø)
access/grpc/grpc.go 79.36% <ø> (ø)
access/http/http.go 72.77% <ø> (ø)
access/http/mock_handler.go 50.58% <ø> (ø)
crypto/awskms/awskms.go 17.07% <ø> (ø)
crypto/awskms/signer.go 0.00% <ø> (ø)
crypto/cloudkms/signer.go 0.00% <ø> (ø)
event.go 0.00% <ø> (ø)
templates/accounts.go 18.46% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nozim
Copy link
Contributor Author

nozim commented Sep 12, 2023

@chasefleming awesome. thanks for help.

@nozim
Copy link
Contributor Author

nozim commented Sep 12, 2023

@chasefleming @sideninja kindly help to review. This should be last one :)

@nozim
Copy link
Contributor Author

nozim commented Sep 14, 2023

@nvdtf @chasefleming kindly help to re-review and merge if all good 🙏

Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nozim Is there an issue to link to? It's a little unclear about what I should be reviewing for.

@nozim
Copy link
Contributor Author

nozim commented Sep 18, 2023

@chasefleming there is no particular issue for this PR. It's rather update of all the examples because they were outdated and did not compile.

@nozim nozim requested a review from chasefleming September 18, 2023 10:43
@nozim
Copy link
Contributor Author

nozim commented Sep 25, 2023

@sideninja @nvdtf kindly help to review and merge if there is no other comments. Thanks

@franklywatson franklywatson merged commit 25dcab0 into onflow:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants