-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update SDK usage examples #447
Conversation
I believe you forgot to mod tidy @nozim |
@sideninja updated, thanks 😊 |
And make sure to regenerate mocks, it looks like that is failing. |
yes, also there is another failing example. Will fix in a bit. Thanks |
@chasefleming mind reviewing? |
@sideninja @chasefleming updated deps and mocks here fc7a435. |
@nozim rerunning |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 62.03% 61.14% -0.90%
==========================================
Files 25 26 +1
Lines 3003 3258 +255
==========================================
+ Hits 1863 1992 +129
- Misses 1016 1099 +83
- Partials 124 167 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@chasefleming awesome. thanks for help. |
@chasefleming @sideninja kindly help to review. This should be last one :) |
@nvdtf @chasefleming kindly help to re-review and merge if all good 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nozim Is there an issue to link to? It's a little unclear about what I should be reviewing for.
@chasefleming there is no particular issue for this PR. It's rather update of all the examples because they were outdated and did not compile. |
@sideninja @nvdtf kindly help to review and merge if there is no other comments. Thanks |
Description
Update examples folder with running examples.
For contributor use:
master
branchFiles changed
in the Github PR explorer