-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Update model Block REST API Response #6884
base: master
Are you sure you want to change the base?
[Access] Update model Block REST API Response #6884
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6884 +/- ##
=======================================
Coverage 41.09% 41.10%
=======================================
Files 2119 2119
Lines 185867 185881 +14
=======================================
+ Hits 76387 76406 +19
+ Misses 103078 103071 -7
- Partials 6402 6404 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. please update the import version to v0.4.9
@@ -323,3 +323,6 @@ require ( | |||
|
|||
// Using custom fork until https://github.com/onflow/flow-go/issues/5338 is resolved | |||
replace github.com/ipfs/boxo => github.com/onflow/boxo v0.0.0-20240201202436-f2477b92f483 | |||
|
|||
// TODO: remove after PR on onflow/flow https://github.com/onflow/flow/pull/1539 merged and flow version bumped | |||
replace github.com/onflow/flow => github.com/The-K-R-O-K/flow v0.0.0-20250123124738-e797132bf24e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new tag is v0.4.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update to the new tag, then this is ready to merge
Closes: #6874
Related PR:
Context
The
omitempty
tag was added to theExpandable
field forBlock
,flow
package version updated