Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update model Block REST API Response #6884

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 14, 2025

Closes: #6874

Related PR:

Context

The omitempty tag was added to the Expandable field for Block, flow package version updated

@UlyanaAndrukhiv UlyanaAndrukhiv requested a review from a team as a code owner January 14, 2025 14:28
@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.10%. Comparing base (43e132e) to head (2a86b08).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
engine/access/rest/common/models/block.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6884   +/-   ##
=======================================
  Coverage   41.09%   41.10%           
=======================================
  Files        2119     2119           
  Lines      185867   185881   +14     
=======================================
+ Hits        76387    76406   +19     
+ Misses     103078   103071    -7     
- Partials     6402     6404    +2     
Flag Coverage Δ
unittests 41.10% <86.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-assigned this Jan 22, 2025
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please update the import version to v0.4.9

@@ -323,3 +323,6 @@ require (

// Using custom fork until https://github.com/onflow/flow-go/issues/5338 is resolved
replace github.com/ipfs/boxo => github.com/onflow/boxo v0.0.0-20240201202436-f2477b92f483

// TODO: remove after PR on onflow/flow https://github.com/onflow/flow/pull/1539 merged and flow version bumped
replace github.com/onflow/flow => github.com/The-K-R-O-K/flow v0.0.0-20250123124738-e797132bf24e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tag is v0.4.9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to the new tag, then this is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Update model Block REST API Response
5 participants