Bump onflow/go-ethereum dependency to v1.14.12
#7175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pectra-upgrade #7175 +/- ##
==========================================================
- Coverage 41.33% 41.30% -0.03%
==========================================================
Files 2164 2164
Lines 189596 189623 +27
==========================================================
- Hits 78370 78333 -37
- Misses 104705 104761 +56
- Partials 6521 6529 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-Peter
force-pushed
the
mpeter/update-go-ethereum-v1.14.12
branch
from
ab2fcde to
e6846a9
Compare
m-Peter
requested review from
a team,
janezpodhostnik and
zhangchiqing
as code owners
6 tasks
Kay-Zee
approved these changes
Apr 2, 2025
m-Peter
changed the base branch from
feature/pectra-upgrade
to
mpeter/update-go-ethereum-v1.14.11
|
|
||
| // SetState adds sets a value for the given slot of the main storage | ||
| func (d *DeltaView) SetState(sk types.SlotAddress, value gethCommon.Hash) error { | ||
| // SetState adds sets a value for the given slot of the main storage. |
Contributor
There was a problem hiding this comment.
Suggested change
| // SetState adds sets a value for the given slot of the main storage. | |
| // SetState sets or adds a value for the given slot of the main storage. |
Comment on lines
+122
to
+123
| balance, err := db.latestView().GetBalance(addr) | ||
| db.handleError(err) |
Contributor
There was a problem hiding this comment.
should this happen before SelfDestruct?
Collaborator
Author
There was a problem hiding this comment.
That's a great catch 💯 Updated in 05b8ee2
| } | ||
|
|
||
| func (db *StateDB) Finalise(deleteEmptyObjects bool) { | ||
| panic(fmt.Errorf("should not be called!")) |
Contributor
There was a problem hiding this comment.
I wonder if it would be better to call Finalise but leave it empty. Might be more in line with how its envisioned.
Collaborator
Author
There was a problem hiding this comment.
Good point indeed. Updated in a69d18c .
janezpodhostnik
approved these changes
Apr 9, 2025
Collaborator
Author
|
Superseded by #7241 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: #7152
Depends on: onflow/go-ethereum#12