Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flow CLI configuration creation #698

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Fix Flow CLI configuration creation #698

merged 3 commits into from
Oct 25, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 25, 2024 •
edited
Loading

Closes #697

Description

Adjust to latest flow init changes

Ignore the failing tests. CI is broken on this repo, they pass locally.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink merged commit 6707d22 into master Oct 25, 2024
3 of 6 checks passed
@jribbink jribbink deleted the jribbink/flow-init branch October 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button to create flow.json file fails
2 participants
@jribbink @chasefleming