Skip to content

Cleaned up mobile menu #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleaned up mobile menu #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions design-system/components/header/css/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ header .logo {
height: var(--size-logo);
padding: calc(var(--spacing-medium) * 1.125) 0;
line-height: var(--line-height-base);
display: flex;
width: fit-content;
position: relative;
top: -1px;
Expand Down Expand Up @@ -111,7 +110,11 @@ nav.staged {
display: none;
}

.open {
header.open {
border-radius: var(--radius-header) var(--radius-header) 0 0 !important;
}

ul.open {
display: initial !important;
}

Expand Down Expand Up @@ -168,7 +171,7 @@ nav .badge {
header.island {
width: fit-content;
margin: var(--spacing-base) auto 0 auto;
border-radius: var(--radius-round);
border-radius: var(--radius-header);
}

header.island .wrapper {
Expand All @@ -195,7 +198,7 @@ header.island nav ul li a.wrapper {
@media (prefers-color-scheme: light) {
header nav ul {
box-shadow: var(--shadow-lm);
background-color: var(--color-light);
background-color: var(--color-light-translucent);
border: var(--border-dark);
}

Expand All @@ -207,9 +210,8 @@ header.island nav ul li a.wrapper {
@media (prefers-color-scheme: dark) {
header nav ul {
box-shadow: var(--shadow-dm);
background-color: var(--color-shade-dm);
background-color: var(--color-dark-translucent);
border: var(--border-light);

}

header nav ul li a:hover {
Expand Down Expand Up @@ -248,15 +250,15 @@ header.island nav ul li a.wrapper {
}

header.island nav ul {
flex-direction: column;
position: absolute;
top: 56px;
right: 0;
width: max-content;
position: fixed;
top: 60px;
right: -1px;
width: 100%;
z-index: 1;
padding: var(--spacing-small) 0;
align-items: flex-start;
border-radius: var(--radius-soft);
border-radius: 0 0 var(--radius-header) var(--radius-header);
backdrop-filter: blur(var(--spacing-base));
-webkit-backdrop-filter: blur(var(--spacing-base));
}

header nav ul li a.wrapper {
Expand Down
2 changes: 2 additions & 0 deletions design-system/components/header/js/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ $(document).ready(function() {

$('.btnIcon').on('click', function() {
$('header nav ul').toggleClass('open');
$('header').toggleClass('open');
});

$('NAV li').on('click', function() {
$('header nav ul').removeClass('open');
$('header').removeClass('open');
});

});
1 change: 1 addition & 0 deletions design-system/css/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,5 @@
--radius-soft: .25rem;
--radius-softer: .5rem;
--radius-round: 50vw;
--radius-header: 30px;
}
2 changes: 2 additions & 0 deletions design-system/js/design-system.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ $(document).ready(function() {

$('.mobileNav').on('click', function() {
$('header nav ul').toggleClass('open');
$('header').toggleClass('open');
if ($('.mobileNav').attr('aria-expanded') == 'false') {
$('.mobileNav').attr('aria-expanded', 'true');
} else {
Expand All @@ -21,6 +22,7 @@ $(document).ready(function() {

$('NAV li').on('click', function() {
$('header nav ul').removeClass('open');
$('header').removeClass('open');
});

$('.bannerBtn').on('click', function() {
Expand Down