fix: text color detection bug fixed #1565
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitenite
reviewed
Mar 9, 2025
| const color = Color.from(colorValue); | ||
|
|
||
| // Only consider it empty if it has zero alpha or exactly equals transparent | ||
| // Don't consider black (#000000) or other valid colors as empty |
There was a problem hiding this comment.
We actually don't consider black empty color. You might be seeing #00000000 which is transparent black. The issue seen is actually that there is no set color on the text color instead of it accidentally seeing black as empty. For example, if you set actual black #000000, it'll show up
Kitenite
reviewed
Mar 9, 2025
| ...selectedEl.styles?.defined, | ||
| }; | ||
| // Debug log to check what styles are coming from the DOM | ||
| console.log('Selected element:', selectedEl.tagName); |
There was a problem hiding this comment.
We shouldn't ship logs in production
Kitenite
reviewed
Mar 9, 2025
| @@ -1,7 +1,7 @@ | |||
| # Only add these if you have valid keys. Otherwise, comment them out. | |||
| VITE_SUPABASE_API_URL= | |||
| VITE_SUPABASE_ANON_KEY= | |||
| VITE_MIXPANEL_TOKEN= | |||
| # VITE_MIXPANEL_TOKEN= | |||
There was a problem hiding this comment.
I would not comment out the example here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When selecting text elements in the editor (particularly headings), the properties panel was displaying text color as #000000 (black) even when the actual text had a different color (like red). This created a disconnect between what users saw in the editor and what was shown in the color properties panel.
My Approach:
Modified the
ColorInputcomponent to better handle text elements(p, h1-h6, span, div)by prioritizing the computed color values directly from the DOM, ensuring that both inherited and applied colors are displayed correctly.Refined the
isColorEmptyutility function to more accurately determine when a color is truly empty, preventing valid color values (such as black) from being incorrectly treated as empty.Related Issues
closes #1528
Type of Change
Screenshots (if applicable)
https://drive.google.com/file/d/1e8t2h5EoVcqeLmFiZyMKZ_ft6KkSCEBH/view?usp=drive_link
Additional Notes