Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases for the ONNX importer #218

Open
tungld opened this issue Jul 14, 2020 · 3 comments
Open

Test cases for the ONNX importer #218

tungld opened this issue Jul 14, 2020 · 3 comments

Comments

@tungld
Copy link
Collaborator

tungld commented Jul 14, 2020 •
edited
Loading

I have sometimes encountered errors related to importing ONNX operators into ONNX dialect, e.g. #217. This happened when working with a new ONNX model.

It is better to have test cases for the importer to make sure that it works well in different situations. Something similar to test cases for shape inference, lowering, etc.
@chentong319
Copy link
Collaborator

Agree. Similar to check-onnx-backend with only --EmitONNXBasic?

@doru1004
Copy link
Collaborator

doru1004 commented Nov 6, 2020

Do we have any updates on this? @tungld @chentong319

@tungld tungld mentioned this issue Jan 14, 2021
Open
@tungld tungld mentioned this issue Feb 1, 2022
Merged
@tungld
Copy link
Collaborator Author

tungld commented Sep 12, 2022

Addressed by #1685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doru1004 @tungld @chentong319