fix: update only the selected file with the SEQ_MS#95
Open
EmmanouilKanellis wants to merge 1 commit into
Open
Conversation
…MS value not all the sequence files Signed-off-by: Emmanouil Kanellis <emka@onomondo.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally the update_seq_data function was updating all sequence files plus the delta file. The fix is to update/write only the selected, by the modem, file and not the rest of the sequence files. With this optimisation onomondo-uicc will not do unnecessary writes to the filesystem.