Handle newline-delimited GeoJSON and large GeoJSON files #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full logs: https://github.com/onthegomap/planetiler/actions/runs/12950545460 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from geotools geojson reader to a custom jackson-streaming based geojson parser that handles newline-delimited geojson and arbitrarily large input files using a minimal memory footprint.
To use it, you can add
.addGeoJsonSource("name", Path.of("path", "to", "file.json"), "https//url/of/file.json")to aPlanetiler.createinstance or to use just the streaming parser:The new parser will throw an exception and abort if the input json has a syntax error, but it will only log warnings and emit empty geometries if the input does not adhere to json semantics.
See RFC 7946 which appears to be the canonical geojson specification now, and this description of newline-delimited geojson format.
Testing on large geojson files converted from overture, it reads about 250k features/150MB per second with fixed memory usage <100MB. There's probably room for improvement from that, but it at least makes processing arbitrarily large files possible.
NOTE:
crswas removed from the spec, so this parser assumes all geojson input files use WGS84 with longitude first, and latitude second. 3d coordinates are ignored.