Skip to content

ci(codeql): add static analysis for the TypeScript side - #149

Closed
Clupai8o0 wants to merge 1 commit into
11.0.xfrom
ci/tci-06-web-codeql
Closed

Clupai8o0 wants to merge 1 commit into
11.0.xfrom
ci/tci-06-web-codeql

Conversation

@Clupai8o0

Copy link
Copy Markdown

TCI-06 leftover (web half), from my product-audit pile. Base 11.0.x.

TCI-06 was about CodeQL wiring on the api repo (already fixed on 11.0.x). While verifying it I confirmed the card's other standing item: doubtfire-web has no codeql.yml at all, so the whole TypeScript/Angular side of the product has no static analysis. This adds one.

Built against

  • web: 11.0.x @ 1671005a

What changed

New .github/workflows/codeql.yml, copied from the api workflow so the two repos read the same:

  • language: ["javascript-typescript"] (the api one is ruby).
  • No Autobuild step — JS/TS is extracted directly, no build needed.
  • Same triggers as api: push on ["11.0.x", "development"], every PR via pull_request: {}, weekly cron, and the same concurrency block.
  • Same SHA-pinned actions: actions/checkout@11d5960 # v4, github/codeql-action/{init,analyze}@6d786de # v3.

It is not wired into branch protection, so it reports as an informational check rather than a required gate until the team decides to require it.

Checks

  • actionlint 1.7.12 → 0 issues.
  • python3 -c "import yaml; yaml.safe_load(...)" → parses.
  • SHA pins are the same 40-char refs the api repo already runs.
  • Not covered: the first real run happens on GitHub after merge; a large TS codebase may surface existing alerts, which is the point of adding it.

doubtfire-web had no CodeQL workflow, so the Angular/TypeScript half of the
product had no static analysis. This mirrors the api workflow with the
javascript-typescript language and no Autobuild step, same SHA-pinned actions,
triggers and concurrency group.
@Clupai8o0
Clupai8o0 requested a review from a team as a code owner August 30, 2026 10:59
@Clupai8o0

Copy link
Copy Markdown
Author

Closing without merging. The premise this was built on is wrong: doubtfire-web has no committed codeql.yml, but CodeQL default setup is enabled on the repo, so the TypeScript side is already analysed. This PR triggered it — the run named CodeQL "via dynamic" on this PR has Analyze (actions) and Analyze (javascript-typescript) jobs, which is the default-setup signature (no workflow file produces those job names).

Adding a committed (advanced) workflow on top of default setup is redundant and GitHub will not process the advanced SARIF while default setup is enabled for the same language. The api repo is the opposite — it runs an advanced committed codeql.yml (CodeQL (ruby)), which is why the concurrency PR there (#114) is valid.

So TCI-06's "web has no static analysis" line does not hold. Nothing to do on web. Leaving default setup as-is.

@Clupai8o0 Clupai8o0 closed this Aug 30, 2026
@Clupai8o0
Clupai8o0 deleted the ci/tci-06-web-codeql branch August 30, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant