Repository navigation
Conversation
doubtfire-web had no CodeQL workflow, so the Angular/TypeScript half of the product had no static analysis. This mirrors the api workflow with the javascript-typescript language and no Autobuild step, same SHA-pinned actions, triggers and concurrency group.
|
Closing without merging. The premise this was built on is wrong: doubtfire-web has no committed Adding a committed (advanced) workflow on top of default setup is redundant and GitHub will not process the advanced SARIF while default setup is enabled for the same language. The api repo is the opposite — it runs an advanced committed So TCI-06's "web has no static analysis" line does not hold. Nothing to do on web. Leaving default setup as-is. |
TCI-06 leftover (web half), from my product-audit pile. Base
11.0.x.TCI-06 was about CodeQL wiring on the api repo (already fixed on
11.0.x). While verifying it I confirmed the card's other standing item: doubtfire-web has nocodeql.ymlat all, so the whole TypeScript/Angular side of the product has no static analysis. This adds one.Built against
11.0.x@1671005aWhat changed
New
.github/workflows/codeql.yml, copied from the api workflow so the two repos read the same:language: ["javascript-typescript"](the api one isruby).Autobuildstep — JS/TS is extracted directly, no build needed.["11.0.x", "development"], every PR viapull_request: {}, weekly cron, and the sameconcurrencyblock.actions/checkout@11d5960 # v4,github/codeql-action/{init,analyze}@6d786de # v3.It is not wired into branch protection, so it reports as an informational check rather than a required gate until the team decides to require it.
Checks
actionlint 1.7.12→ 0 issues.python3 -c "import yaml; yaml.safe_load(...)"→ parses.