Added recursive cloning required for some packages#291
Open
danielsvane wants to merge 1 commit intooortcloud:windows-updatesfrom
Open
Added recursive cloning required for some packages#291danielsvane wants to merge 1 commit intooortcloud:windows-updatesfrom
danielsvane wants to merge 1 commit intooortcloud:windows-updatesfrom
Conversation
Member
|
Hey @danielsvane -- we already run What package were you having this problem with? |
Author
|
I had the problem with the Moment package: https://github.com/acreeger/meteor-moment. I can't seem to be able to reproduce the problem now, but it was definitely a problem with submodule, as it was the only package using it. It seems like others has had the same issue: acreeger/meteor-moment#16. As I can't reproduce it, and you already handle submodules, no reason to merge. Just to be sure, you know this is a pull request for the windows-updates branch, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.