Skip to content

Conversation

@wanhakim
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 10, 2025 01:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Playwright end-to-end tests for fine-tuning workflows and implements several fixes related to fine-tuning functionality, error handling, and the download process.

  • Adds three new Playwright test files for fine-tuning: rerank, embedding, and reasoning
  • Refactors fine-tuning job download logic to use archiver instead of tar, with improved zip file lifecycle management
  • Adds payload sanitization for fine-tuning job creation to handle edge cases with padding, preprocessor types, and DDP configuration
  • Improves error handling in the UI for sample workflow imports and job deletion

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/test-files/toy_finetune_data.jsonl Added test data for embedding and rerank fine-tuning tests
tests/test-files/medical_o1_sft_50.json Added test data for reasoning fine-tuning tests
tests/playwright/utils.ts Updated status text checking to handle 'failed' status in addition to 'Error'
tests/playwright/studio-e2e/007_test_funetuning_reasoning.spec.ts Added new Playwright test for fine-tuning reasoning workflow
tests/playwright/studio-e2e/006_test_funetuning_embedding.spec.ts Added new Playwright test for fine-tuning embedding workflow
tests/playwright/studio-e2e/005_test_funetuning_rerank.spec.ts Added new Playwright test for fine-tuning rerank workflow
studio-frontend/packages/ui/src/views/opeaflows/index.jsx Added error state and Alert component to display import errors
studio-frontend/packages/ui/src/views/finetuning/FinetuningJobsTable.jsx Replaced browser confirm dialog with custom Material-UI Dialog for job deletion
studio-frontend/packages/server/src/ws/finetuningDownload.ts Updated to use new prepareFineTuningOutputZip function and emit progress immediately
studio-frontend/packages/server/src/services/finetuning/index.ts Major refactor: added payload sanitization, replaced tar with archiver, split download logic
studio-frontend/packages/server/src/controllers/finetuning/index.ts Added zip file cleanup after download completes
studio-frontend/packages/server/package.json Added archiver dependency and its TypeScript types
studio-backend/tests/requirements.txt Added urllib3 version constraint
studio-backend/app/routers/sandbox_router.py Added traceback printing for better error diagnostics
studio-backend/app/requirements.txt Added urllib3 version constraint
setup-scripts/setup-genai-studio/manifests/studio-manifest.yaml Increased storage request from 1Gi to 30Gi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant