✨ Update clustermanager API spec for auto approval identities #357
+86
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jeffw17 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikeshng
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Type: "FieldValueRequired",
Message: "Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property",
Field: "spec.validation.openAPIV3Schema.properties[spec].properties[registrationConfiguration].properties[autoApprovalIdentities].items.properties[driver].default",
RegistrationDrivers didn't have this issue so maybe use that as reference.
jeffw17
force-pushed
the
feature/auto-approval-registration
branch
2 times, most recently
from
92ff577 to
9492e04
Compare
Signed-off-by: “Jeffrey <[email protected]>
jeffw17
force-pushed
the
feature/auto-approval-registration
branch
from
9492e04 to
ec28f1b
Compare
|
/assign @skeeey @xuezhaojun |
|
We may need to mark the |
skeeey
reviewed
Feb 7, 2025
| // +kubebuilder:validation:Enum=csr;awsirsa | ||
| Driver string `json:"driver,omitempty"` | ||
|
|
||
| // Identities represent a list of users in which we will allow to join with hub cluster |
There was a problem hiding this comment.
may need more comments here
- for csr driver, the identities represent a list of users ...
- for awsirsa driver, the identities represent a list of arns ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to add a new field in the RegistrationHubConfiguration for clustermanager to store AutoApprovalIdentities for both CSR and AWSIRSA auth type.
Related issue(s)
Fixes # #514 and #822