Skip to content

✨ [Integrate OCM with Kueue] Add Helm chart for resource-usage-collect-addon #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Konikz
Copy link

@Konikz Konikz commented Apr 5, 2025

✨ [Integrate OCM with Kueue] Add Helm chart for resource-usage-collect-addon - Closes #904

Summary

This PR adds a Helm chart for the resource-usage-collect-addon, replacing the direct YAML installation method. The changes include:

  • Created Helm chart structure with all necessary components:
    • Chart.yaml with proper metadata
    • values.yaml with configurable parameters
    • Templates for ClusterManagementAddOn, AddOnTemplate, RBAC, and agent deployment
  • Added test suite for verification:
    • Test templates for all major components
    • Test values file
    • Test script for automated testing
  • Added migration guide from YAML to Helm installation
  • Updated documentation with installation and configuration details

Related issue(s)

Fixes #904

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker April 5, 2025 18:26
Copy link
Contributor

openshift-ci bot commented Apr 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Konikz
Once this PR has been reviewed and has the lgtm label, please assign jnpacker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

I would suggest we make this PR in addon-contrib repo.

@haoqing0110
Copy link
Member

@Konikz, thanks for your contribution! As Jian Qiu suggests, the chart should be listed under https://github.com/open-cluster-management-io/addon-contrib/tree/main/resource-usage-collect-addon. Could you help to create a PR under addon-contrib?

@Konikz
Copy link
Author

Konikz commented Apr 7, 2025

Sure, i'll get it done

@Konikz
Copy link
Author

Konikz commented Apr 15, 2025

Hi @qiujian16 and @haoqing0110 ,

As discussed above, I've created a new PR in the addon-contrib repo for the Helm chart implementation. The new PR can be found here: open-cluster-management-io/addon-contrib#29

Please review the changes in the addon-contrib repository. Once approved, we can close this PR #936

Thank you!

@haoqing0110
Copy link
Member

close and new PR is open-cluster-management-io/addon-contrib#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integrate OCM with Kueue] Install resource-usage-collect-addon with helm chart
3 participants