Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add faq page #448

Merged

Conversation

haoqing0110
Copy link
Member

Signed-off-by: Qing Hao <[email protected]>
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit c85b12b
🔍 Latest deploy log https://app.netlify.com/sites/open-cluster-management/deploys/677d0442bfc75d0008ab7b41
😎 Deploy Preview https://deploy-preview-448--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haoqing0110
Copy link
Member Author

/assign @qiujian16 @mikeshng

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Silly question: do we need to add a link to the faq or the framework will take care of it?

@openshift-ci openshift-ci bot added the lgtm label Jan 7, 2025
@xuezhaojun
Copy link
Member

/lgtm

Silly question: do we need to add a link to the faq or the framework will take care of it?

Can we explore the question "adding a link to the FAQ"? Do you mean adding links from other pages to the FAQ page?

BTW, netlify provides the preview of this PR, we can check in https://deploy-preview-448--open-cluster-management.netlify.app/ to see if result match our exception.

@mikeshng
Copy link
Member

mikeshng commented Jan 8, 2025

The preview answered my question! This is great @xuezhaojun

/approve

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 04ec284 into open-cluster-management-io:main Jan 8, 2025
7 checks passed
@haoqing0110 haoqing0110 deleted the br_faq branch January 8, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants