Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge policy into one section #449

Merged

Conversation

haoqing0110
Copy link
Member

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit bc08f79
🔍 Latest deploy log https://app.netlify.com/sites/open-cluster-management/deploys/6788bb2ad8b8c60008ff7991
😎 Deploy Preview https://deploy-preview-449--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qiujian16
Copy link
Member

/assign @dhaiducek

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @haoqing0110!

I think this isn't quite the landing page we'd want for Policy, but I'm fine if it merges as-is. I can follow it up with another PR to reflow it.

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2025
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, haoqing0110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a90c9b into open-cluster-management-io:main Jan 16, 2025
7 checks passed
@haoqing0110
Copy link
Member Author

@dhaiducek We discussed the community meeting open-cluster-management-io/ocm#781 and felt that grouping current concepts into 4 sections "Cluster Inventory", "Work Distribution", "Content Placement", "Add-On Extensibility" is more clear for the user, so move policy into addon-integrations.

The policy's link is still on the homepage.
Screenshot 2025-01-17 at 10 12 15

@haoqing0110 haoqing0110 deleted the br_addon branch January 17, 2025 02:13
@dhaiducek
Copy link
Member

Oh, nice! I don't think I was aware Policy was linked directly from the homepage! 🎉 Yes, I agree it absolutely makes sense. I was just commenting I'll do some rearranging--or, more likely, add to/update the content--on this page now that it's the landing page for everything policy and not just ConfigurationPolicy/Gatekeeper: https://open-cluster-management.io/docs/getting-started/integration/policy-controllers/

@haoqing0110
Copy link
Member Author

@dhaiducek yes, plz, it would be great if you could help with this, you are the expert.

@dhaiducek dhaiducek mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants