Fix issues with SqlMagic (prettytable) and arrow dependency conflict (edited in Colab) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
|
@ColinMaudry I will resolve the reported lint issue here as it relates to something you haven't touched |
|
Thanks! |
|
I fixed the lint on main. |
|
I think part of this needs to be fixed in kingfisher-colab instead. Its tests are failing (probably due to a updated dependency causing issues). |
|
Indeed, prettytable just needs to be frozen to 3.11.0 catherinedevlin/ipython-sql#252 https://github.com/prettytable/prettytable/releases/tag/3.12.0 ipython-sql doesn't interact with prettytable through its |
jpmckinney
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source @allakulov: Slack
Same PR as #74 but edited in Colab instead of locally.