Skip to content

Conversation

askpt
Copy link
Member

@askpt askpt commented Aug 22, 2025

This PR

This pull request removes custom NuGet package source configuration and related authentication from the CI/CD pipeline. The main change is the elimination of references to the GitHub-hosted NuGet feed for the open-feature organization, simplifying package management and build configuration.

CI/CD workflow simplification:

  • Removed NUGET_AUTH_TOKEN environment variable and source-url pointing to the GitHub NuGet feed from the .github/workflows/ci.yml, .github/workflows/code-coverage.yml, .github/workflows/e2e.yml, and .github/workflows/release.yml workflows, so the builds now use only the default NuGet source. [1] [2] [3] [4] [5]

Configuration cleanup:

  • Deleted the nuget.config file, which previously specified both the public NuGet feed and the GitHub-hosted feed, along with source mapping rules for OpenFeature packages.

Related Issues

Fixes #540

Notes

  • This file and configurations are not needed. We don't consume any nuget package from the GitHub registry, we only push. So this configuration is not necessary and it will make the onboarding and actions easier.

@askpt askpt linked an issue Aug 22, 2025 that may be closed by this pull request
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (5630d2b) to head (96d08ae).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          64       64           
  Lines        2509     2509           
  Branches      296      296           
=======================================
  Hits         2250     2250           
  Misses        199      199           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@askpt askpt marked this pull request as ready for review August 22, 2025 14:44
@askpt askpt requested a review from a team as a code owner August 22, 2025 14:44
@askpt askpt changed the title build: remove root nuget.config file build: Remove root nuget.config file Aug 22, 2025
@askpt
Copy link
Member Author

askpt commented Aug 25, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the nuget.config file, simplifying the build process. As noted in the review comment, the previous configuration had an ambiguous package source mapping which could lead to non-deterministic builds. Deleting the file is the right move to improve build reliability and maintainability.

@askpt askpt added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit 81ac214 Aug 25, 2025
19 checks passed
@askpt askpt deleted the askpt/540-investigate-necessity-of-root-nugetconfig-file branch August 25, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate necessity of root nuget.config file
3 participants