Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: OTel hook changes for hook interface updates #644

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bbland1
Copy link

@bbland1 bbland1 commented Mar 5, 2025

This PR

  • bumped the go-sdk version to 1.14.1
  • added evalDetails to the parameters passed in the Finally hook in metrics hook
  • updated the metrics_test to have the new evalDetails

Related Issues

Fixes #642

Notes

  • not sure if there is a specific way to bump the go-sdk version to the unreleased version with the change to the Hook it currently throws an error where it is called in metrics because the type issue
var _ openfeature.Hook = &MetricsHook{}
  • in the issue it states to explicitly mention the breaking but ok because of spec in the release notes, I am not sure if that is something I can do in this PR and I just can't find how in the contributing or if it is after the reviewing

@bbland1 bbland1 requested a review from a team as a code owner March 5, 2025 20:20
@github-actions github-actions bot requested a review from Kavindu-Dodan March 5, 2025 20:20
@bbland1 bbland1 changed the title feat!: updated OTel finally hook for upcoming changes feat!: OTel hook changes for hook interface updates Mar 5, 2025
@beeme1mr beeme1mr requested a review from toddbaert March 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade OTel hook
2 participants