Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement multi provider #645

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat: implement multi provider #645

wants to merge 24 commits into from

Conversation

bbland1
Copy link

@bbland1 bbland1 commented Mar 6, 2025

This PR

  • adds this new feature

Related Issues

Fixes #599

Notes

Follow-up Tasks

How to test

@bbland1 bbland1 changed the title 599/implement multi provider feat:implement multi provider Mar 6, 2025
@bbland1 bbland1 changed the title feat:implement multi provider feat: implement multi provider Mar 6, 2025
bbland1 and others added 20 commits March 8, 2025 18:40
@bbland1
feat(multi-provider): set up multi-provider directory
089c098 
Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: set up func to create new multiprovider & register passed provi…
b8275df 
…ders

Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: added Metadata Method to the multiprovider
6ef2dd8 
Signed-off-by: bbland1 <[email protected]>
@bbland1
feat: added the based of the Init method that will process the inital…
63a5300 
…ize of the providers

Signed-off-by: bbland1 <[email protected]>
@bbland1
moved providers into pkg directory
ac9ab37 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added Init method to handle any providers with intialization
65e2f04 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added the Shutdown method
dd933fb 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added getter methods to the unexported fields
32af790 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added tests to check unique name for providers passed
c6aaf74 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test checking if error thrown for unique name if not unique
70878e5 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test to check for metadata, currently fails
d5f3d6a 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test for getter methods of the struct provider entries
a3ba348 
Signed-off-by: bbland1 <[email protected]>
@cupofcat @bbland1
chore(flagd): Updates flagd core to v0.11.2 (open-feature#636)
efa68b9 
Signed-off-by: Maks Osowski <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@cupofcat @bbland1
feat(flagd): Added WithGrpcDialOptionsOverride provider option (open-…
0ac6343 
…feature#638)

Signed-off-by: Maks Osowski <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@github-actions @bbland1
chore(main): release providers/flagd 0.2.6 (open-feature#635)
270f5e5 
Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <[email protected]>
@toddbaert @aimuz @bbland1
fix(deps): Remove dependency on sigs.k8s.io/controller-runtime/pkg/lo… (
0067b34 
open-feature#639)

Signed-off-by: aimuz <[email protected]>
Co-authored-by: aimuz <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@thomaspoignant @bbland1
chore(go-feature-flag): Support new hook format (open-feature#641)
4e259c6 
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: bbland1 <[email protected]>
@github-actions @bbland1
chore(main): release providers/go-feature-flag 0.2.4 (open-feature#643)
e225fbd 
Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: bbland1 <[email protected]>
@bbland1
added test for MP Init method with mock providers that have Init methods
ac2f314 
Signed-off-by: bbland1 <[email protected]>
@bbland1
added shutdown test confirming method run in MP when called
2d6f44b 
Signed-off-by: bbland1 <[email protected]>
@bbland1 bbland1 force-pushed the 599/implement-multi-provider branch from c3f9e57 to 2d6f44b Compare March 8, 2025 23:40
@github-actions github-actions bot requested a review from toddbaert March 8, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl Awaiting requested review from bacherfl

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@toddbaert toddbaert Awaiting requested review from toddbaert

At least 1 approving review is required to merge this pull request.

Assignees

@bacherfl bacherfl

@Kavindu-Dodan Kavindu-Dodan

@thomaspoignant thomaspoignant

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Multi-Provider
6 participants
@bbland1 @bacherfl @Kavindu-Dodan @thomaspoignant @toddbaert @cupofcat