test(flagd): adding configuration gherkin tests #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphael Wigoutschnigg <[email protected]>
Signed-off-by: Raphael Wigoutschnigg <[email protected]>
aepfli
reviewed
Mar 20, 2025
providers/flagd/pkg/provider.go
Outdated
| @@ -235,147 +195,147 @@ func (p *Provider) setStatus(status of.State) { | |||
|
|
|||
| // ProviderOptions | |||
|
|
|||
| type ProviderOption func(*Provider) | |||
| type ProviderOption func(*ProviderConfiguration) | |||
There was a problem hiding this comment.
should those methods also be part of the configuration.go? as they are really configuration related?
| } | ||
|
|
||
| // providerOptionGeneratorMap a map that defines the provider options generators for supported options | ||
| var providerOptionGeneratorMap = map[string]func(value string) (flagd.ProviderOption, error){ |
There was a problem hiding this comment.
do we really need this mapping? we can access the properties of the providerConfiguration directly - the helper methods are nice and simulate a more go like way, but i think we can run this test with directly setting the properties, wdyt? we even could set those fields via reflection
Signed-off-by: Raphael Wigoutschnigg <[email protected]>
aepfli
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
adding configuration gherkin tests