feat: add evaluation details to finally hook

[bbland1]

This PR

• adds evaluation details to finally hook stage
• utilized InterfaceEvaluationDetails similar to the After method of the hook

Related Issues

Fixes #327

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- Finally(ctx context.Context, hookContext HookContext, hookHints HookHints)
+ Finally(ctx context.Context, hookContext HookContext, flagEvaluationDetails InterfaceEvaluationDetails, hookHints HookHints)

Follow-up Tasks

Update the go-sdk-contrib repo, with a quick search the few places finally is being used that I saw.

• go-feature-flag data
• go-feature-flag evaluation
• open-telemetry metrics
• open-telemetry metrics-test

How to test

• Running local unit tests passed again with change to interface.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (3c70dc2) to head (dca32b5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files          14       14           
  Lines        1408     1408           
=======================================
  Hits         1241     1241           
  Misses        143      143           
  Partials       24       24           

Flag	Coverage Δ
e2e	88.13% <100.00%> (ø)
unit	88.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[toddbaert]

Looks good to me. This is more straightforward in Go because there's no try/catch causing scope difficulties with the evalDetails as in other SDKs.

Thanks again for your 2nd PR (I think) @bbland1 !

Before we release this we'll have to make this (small) breaking change clear in the release notes.... just saying it now so I don't forget it.

@bbland1 consider joining the org: open-feature/community#433

[beeme1mr]

Let's make sure to coordinate with @thomaspoignant. This breaking change was easier in other languages since it was unlikely to affect people. However, this change will definitely have at least some impact and we should do what we can to minimize it.

[bbland1]

@toddbaert thank you, I enjoyed getting to work on the PRs!

@beeme1mr & @thomaspoignant if I remember correctly for go-feature-flag the Finally didn't have specific logic containing just implementing to satisfy the interface so 🤞🏽 impact isn't too bad. I think the open-telemetry maybe had some logic in it's implementation.

[thomaspoignant]

Sorry for the late reply.
I have open a PR for GO Feature Flag to support the finally open-feature/go-sdk-contrib#641.

[beeme1mr]

Okay, I'll merged tomorrow unless someone objects. I've also created an issue to upgrade the OTel hook. We'll want to make sure this is released around the same time as the Go SDK.