-
Notifications
You must be signed in to change notification settings - Fork 52
feat(go-feature-flag)!: Introduce in-process evaluation + tracking #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
796b058
to
938e5c5
Compare
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
a3f31fd
to
3e777b2
Compare
b328b00
to
25ecbc0
Compare
31a3135
to
63912db
Compare
Signed-off-by: Thomas Poignant <[email protected]>
63912db
to
e7d1385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good :)
Added some comments.
Adding a section to the PR and the readme on the motivation to do in-process evaluation inside the provider can be nice too.
...flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
Outdated
Show resolved
Hide resolved
...flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
Outdated
Show resolved
Hide resolved
...flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
Show resolved
Hide resolved
...flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
Show resolved
Hide resolved
...flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java
Outdated
Show resolved
Hide resolved
...-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/wasm/EvaluationWasm.java
Outdated
Show resolved
Hide resolved
...-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/wasm/EvaluationWasm.java
Show resolved
Hide resolved
0bbfee1
to
5259359
Compare
Signed-off-by: Thomas Poignant <[email protected]>
5259359
to
4b234e6
Compare
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant I'm very interested in this! I don't have time to review today but I will on Friday (not that you have to wait for my approval) since this is all GoFF. |
cc @beeme1mr this uses WASM, you might be interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool.
I was worried about making sure all the memory resources were cleaned/closed, but it looks like chicory is doing most of that for you (which is cool). Things make sense to me. Very interested to see how this works at scale.
I left one comment because I think you are possibly missing some Jackson deps.
You might also want to mention tracking in your title. |
36a2b4b
to
dc85570
Compare
Signed-off-by: Thomas Poignant <[email protected]>
dc85570
to
cdcb095
Compare
This PR
This is a complete rebuild of the GO Feature Flag provider.
This version is using a webassembly module to do in-process evaluation inside the provider.
You can still use the remote evaluation if you prefer through the OFREP endpoint of GO Feature Flag.
Things to know:
process-resources
of maven using this script.