feat: add evaluation-scoped hook data #1216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Developer <[email protected]>
beeme1mr
commented
Jun 6, 2025
kinyoklion
reviewed
Jun 6, 2025
|
I'm going to switch to a draft. I found a number of issues when I removed the weak map. |
Signed-off-by: Michael Beemer <[email protected]>
lukas-reining
approved these changes
Jun 10, 2025
Signed-off-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1215
Notes
I had to add a bit more complexity in order to maintain support for existing hook implementations that used weakmaps.
How to test
Unit tests have been added