Restructure modules #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
14 tasks
ajhelsby
force-pushed
the
restructure-modules
branch
from
bca1e0b to
4f07a28
Compare
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>
ajhelsby
force-pushed
the
restructure-modules
branch
from
06c7673 to
f725c85
Compare
matthewelwell
approved these changes
Jun 30, 2022
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "python_open_feature_sdk" |
There was a problem hiding this comment.
We may want to change this - I'm not sure if there are any conventions we need to follow. But it's not important for this PR.
There was a problem hiding this comment.
Easy enough to change at another point
|
@toddbaert @justinabrahms would you like to review this before we merge? I guess generally, would you prefer us to work autonomously on this or would you like to review each PR before it's merged? |
|
I'd prefer for you to work autonomously and request feedback if you want an opinion. Then we can do periodic reviews like Todd did for me. |
|
Understood, thanks @justinabrahms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.