fix: CocoaPods publishing workflow #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
The CocoaPods publishing has been failing due to two issues: 1. The pod-publish job had an overly restrictive condition that only allowed publishing from GitHub release events. When called from release-please via workflow_call, the event name is inherited as 'push', causing the job to be skipped. 2. The workflow referenced ./scripts/update_podspec.sh which was deleted in commit 2903008 when release-please was configured to handle version updates automatically. This commit fixes both issues by removing the unnecessary condition (release-please already guards with release_created) and removing the reference to the deleted script. Signed-off-by: Sameeran Kunche <[email protected]>
sameerank
force-pushed
the
fix/cocoapods-publishing-workflow
branch
from
75cbec7 to
2906a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
update_podspec.shscript from the CocoaPods workflowRelated Issues
Fixes #91
Notes
2 issues
pod-publishcondition isswift-sdk/.github/workflows/cocoapods.yaml
Line 23 in 09ca50a
pusheventsswift-sdk/.github/workflows/release-please.yaml
Lines 1 to 4 in 09ca50a
workflow_callswift-sdk/.github/workflows/release-please.yaml
Line 38 in 09ca50a
swift-sdk/.github/workflows/cocoapods.yaml
Line 5 in 09ca50a
workflow_callfrom a push-triggered workflow, the event context is inherited according to GitHub documentation and GitHub issue #3146, sogithub.event_namewould be 'push', not 'release'release_createdcheckevent_namechecks in the other OpenFeature SDKs using release-pleaseupdate_podspec.shscript was removed in 2903008 when release-please was configured to automatically manage the podspec version. However, the CocoaPods workflow still referenced this missing script, which would cause the publishing step to fail.# x-release-please-versioncommentswift-sdk/OpenFeature.podspec
Line 3 in 09ca50a
is a release-please marker that tells release-please to automatically update the version number on that line during the release process. This generic updater works with any file type when configured in the
extra-filesoption, eliminating the need for a separate script to update versions.swift-sdk/release-please-config.json
Lines 10 to 13 in 09ca50a
./scripts/update_podspec.shin workflowFollow-up Tasks
How to test
Will have to see if it works with the next release and check logs if it fails.